Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DXCDT-496] Update to go-auth0 v1 #783

Merged
merged 6 commits into from
Aug 1, 2023
Merged

[DXCDT-496] Update to go-auth0 v1 #783

merged 6 commits into from
Aug 1, 2023

Conversation

ewanharris
Copy link
Contributor

🔧 Changes

Updates go-auth0 to v1 and then makes the necessary edits. A summary of each commit is:

  • Update to go-auth0 v1 9988e89
  • Update the go-auth0 interface and regenerate mocks c132ca3
  • Update the usage of go-auth0 8f8bf97
  • Update tests 5fb7ba0

Currently the retry strategy is kept to the default one, I wasn't sure whether it would be good to add to the status codes similar to the terraform provider

📚 References

https://github.com/auth0/go-auth0/releases/tag/v1.0.0

🔬 Testing

Ran tests locally and all pass

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ewanharris ewanharris requested a review from a team as a code owner July 31, 2023 10:20
@ewanharris ewanharris changed the title Update to go-auth0 v1 [DXCDT-496] Update to go-auth0 v1 Jul 31, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 84.11% and project coverage change: -0.02% ⚠️

Comparison is base (2f4e29e) 72.07% compared to head (5fb7ba0) 72.06%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   72.07%   72.06%   -0.02%     
==========================================
  Files          89       89              
  Lines       11156    11158       +2     
==========================================
  Hits         8041     8041              
- Misses       2613     2615       +2     
  Partials      502      502
Files Changed Coverage Δ
internal/cli/arguments.go 21.62% <0.00%> (ø)
internal/cli/flags.go 62.80% <0.00%> (ø)
internal/cli/log_streams_event_grid.go 43.47% <0.00%> (ø)
internal/cli/tenants.go 63.26% <0.00%> (ø)
internal/cli/test.go 46.80% <33.33%> (-0.17%) ⬇️
internal/cli/quickstarts.go 58.00% <50.00%> (ø)
internal/cli/users_blocks.go 69.44% <50.00%> (ø)
internal/cli/roles_permissions.go 62.25% <55.55%> (ø)
internal/cli/email_templates.go 72.25% <60.00%> (ø)
internal/cli/utils_shared.go 55.61% <62.50%> (ø)
... and 24 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

willvedd
willvedd approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

sergiught
sergiught approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @ewanharris 🎉

@sergiught sergiught merged commit 4d5afa9 into main Aug 1, 2023
6 checks passed
@sergiught sergiught deleted the chore/DXCDT-496-go-auth0-update branch August 1, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willvedd willvedd willvedd approved these changes

@sergiught sergiught sergiught approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewanharris @codecov-commenter @willvedd @sergiught